Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24394 )
Change subject: IMPALA-15065: Fix incorrect partition spec identification when removing deletion vectors from Iceberg V3 tables ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24394/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/24394/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1779 PS2, Line 1779: Scans the current snapshot's delete manifests to find the live DeleteFile entry : * for the deletion vector that covers I think we should find the base snapshot's DV, because in the backend we merged the new DV against that. If it is no longer available because another DV superseded it, we should fail the DML statement. Otherwise it could undelete rows. Or am I missing something? -- To view, visit http://gerrit.cloudera.org:8080/24394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba280972e2089e92771c8b3f7355d916d46ad968 Gerrit-Change-Number: 24394 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 03 Jun 2026 12:26:23 +0000 Gerrit-HasComments: Yes
