Hello Peter Rozsa, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24382
to look at the new patch set (#4).
Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in
impala-shell
......................................................................
IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
Bumping to 0.23.0 fixed THRIFT-792 and allowed inspecting actual
socket errors. This revealed that the negative tests for non-http
hs2 tests with verify_cert did not fail due to server verification
- instead verification was not even tried.
See https://github.com/cloudera/impyla/pull/609 for more details.
This patch fixes verify_cert with binary connections and updates
SSL tests to expect the correct error. impyla dependency is also
bumped to get the fix above.
The generated Python files are not regenerated. There
were no compiler changes between 0.22.0 and 0.23.0.
Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
---
M infra/python/deps/requirements.txt
M shell/impala_shell/impala_client.py
M shell/requirements.txt
M tests/custom_cluster/test_client_ssl.py
M tests/custom_cluster/test_ipv6.py
5 files changed, 31 insertions(+), 37 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/24382/4
--
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>