Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24008 )
Change subject: IMPALA-14332: Add X-Request-Id as HttpRequestId attribute on root OTel span ...................................................................... IMPALA-14332: Add X-Request-Id as HttpRequestId attribute on root OTel span When using the hs2-http protocol, the X-Request-Id HTTP header value is now captured and added as an attribute named "HttpRequestId" on the root OpenTelemetry span. The iteration count suffix (e.g., "-8" in "uuid-8") that the Impala shell appends is automatically removed to provide a clean UUID for tracing. Implementation details: - Capture X-Request-Id header in THttpServer and store in ConnectionContext - Propagate value to SessionState during session creation - Add HttpRequestId attribute to root span in SpanManager constructor Testing: - Added C++ unit tests (otel-test.cc) for request ID processing - Added Python integration test using ImpalaHS2Client over hs2-http - Test verifies HttpRequestId attribute format and cross-checks with logs Change-Id: I9e14f5b503ff7379463332bae34c266afc395524 Reviewed-on: http://gerrit.cloudera.org:8080/24008 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Michael Smith <[email protected]> --- M be/src/observe/otel-trace-manager-test.cc M be/src/observe/otel-trace-manager.cc M be/src/observe/otel-trace-manager.h M be/src/rpc/authentication.cc M be/src/rpc/thrift-server.h M be/src/service/impala-hs2-server.cc M be/src/service/impala-server.h M be/src/transport/THttpServer.cpp M be/src/transport/THttpServer.h M tests/custom_cluster/test_otel_trace.py M tests/util/otel_trace.py 11 files changed, 254 insertions(+), 14 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved Michael Smith: Verified -- To view, visit http://gerrit.cloudera.org:8080/24008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9e14f5b503ff7379463332bae34c266afc395524 Gerrit-Change-Number: 24008 Gerrit-PatchSet: 12 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
