Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20386 )
Change subject: IMPALA-12389: Use -skipTrash to avoid accumulating trash ...................................................................... Patch Set 12: (1 comment) Looks good, but I'm not actually sure we need to stop using WebHDFS.delete. http://gerrit.cloudera.org:8080/#/c/20386/12/tests/util/hdfs_util.py File tests/util/hdfs_util.py: http://gerrit.cloudera.org:8080/#/c/20386/12/tests/util/hdfs_util.py@100 PS12, Line 100: return self.hdfs_filesystem_client.delete_file_dir(path, recursive=recursive) Are you sure this is needed? From what I can tell the WebHDFS interface always deletes the file, it never moves them to trash. That behavior is noted in https://issues.apache.org/jira/browse/HDFS-14320, and the code around this doesn't seem to have changed much since 2019. -- To view, visit http://gerrit.cloudera.org:8080/20386 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d304113596aaf70a122202a33276fc7c3d599e8 Gerrit-Change-Number: 20386 Gerrit-PatchSet: 12 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 03 Jun 2026 21:24:13 +0000 Gerrit-HasComments: Yes
