Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24132 )
Change subject: IMPALA-14851: Codegen GroupingAggregator::CopyGroupingValues ...................................................................... Patch Set 8: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/24132/8/be/src/exec/grouping-aggregator-ir.cc File be/src/exec/grouping-aggregator-ir.cc: http://gerrit.cloudera.org:8080/#/c/24132/8/be/src/exec/grouping-aggregator-ir.cc@270 PS8, Line 270: const int tuple_data_size The logic is pre-existing logic, but this seems to have potential int overflow, while TryAllocate uses int64_t for size, maybe better to update tuple_data_size to int64_t. "const int64_t tuple_data_size = static_cast<int64_t>(fixed_size) + varlen_size;" http://gerrit.cloudera.org:8080/#/c/24132/8/be/src/exec/grouping-aggregator-ir.cc@295 PS8, Line 295: const int tuple_size = fixed_size + varlen_size; Same as above, seems int64_t is better. "const int64_t tuple_data_size = static_cast<int64_t>(fixed_size) + varlen_size;" http://gerrit.cloudera.org:8080/#/c/24132/7/be/src/exec/grouping-aggregator.cc File be/src/exec/grouping-aggregator.cc: http://gerrit.cloudera.org:8080/#/c/24132/7/be/src/exec/grouping-aggregator.cc@1319 PS7, Line 1319: // Copy fixed len slots > I found it better to remove it than assert: Ack http://gerrit.cloudera.org:8080/#/c/24132/8/be/src/exec/grouping-aggregator.cc File be/src/exec/grouping-aggregator.cc: http://gerrit.cloudera.org:8080/#/c/24132/8/be/src/exec/grouping-aggregator.cc@1312 PS8, Line 1312: llvm::Value* args[4]; better to be "args[3]" after removing the varlen_size -- To view, visit http://gerrit.cloudera.org:8080/24132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c54a5745ba05a926795318d3b074fde6d0c00a Gerrit-Change-Number: 24132 Gerrit-PatchSet: 8 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 04 Jun 2026 04:42:54 +0000 Gerrit-HasComments: Yes
