Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24403 )
Change subject: IMPALA-14702: Add ability to build against Google Tcmalloc ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/24403/1/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24403/1/be/CMakeLists.txt@760 PS1, Line 760: elseif("$ENV{IMPALA_MALLOC_IMPL}" STREQUAL "gperftools") : set (IMPALA_LINK_LIBS ${IMPALA_LINK_LIBS} MallocUtilGperftools) : set (UNIFIED_TEST_LINK_LIBS ${UNIFIED_TEST_LINK_LIBS} MallocUtilGperftools) : elseif("$ENV{IMPALA_MALLOC_IMPL}" STREQUAL "googletcmalloc") : set (IMPALA_LINK_LIBS ${IMPALA_LINK_LIBS} MallocUtilGoogleTcmalloc) : set (UNIFIED_TEST_LINK_LIBS ${UNIFIED_TEST_LINK_LIBS} MallocUtilGoogleTcmalloc) : else() : message(FATAL_ERROR "Unknown IMPALA_MALLOC_IMPL: $ENV{IMPALA_MALLOC_IMPL}") : endif() > This doesn't seem to work with clang tidy, so it may need additional condit Done http://gerrit.cloudera.org:8080/#/c/24403/1/be/src/runtime/bufferpool/system-allocator.h File be/src/runtime/bufferpool/system-allocator.h: http://gerrit.cloudera.org:8080/#/c/24403/1/be/src/runtime/bufferpool/system-allocator.h@51 PS1, Line 51: bool madvise_unnecessary_ = false; > Nit: add comment Done http://gerrit.cloudera.org:8080/#/c/24403/1/be/src/util/CMakeLists.txt File be/src/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24403/1/be/src/util/CMakeLists.txt@171 PS1, Line 171: add_library(MallocUtilGoogleTcmalloc : malloc-util.cc : ) : add_dependencies(MallocUtilGoogleTcmalloc gen-deps) : target_compile_definitions(MallocUtilGoogleTcmalloc : PRIVATE MALLOC_UTIL_GOOGLETCMALLOC_IMPL) : target_link_libraries(MallocUtilGoogleTcmalloc tcmalloc::tcmalloc) > This doesn't seem to work with clang tidy, so this will need additional con Done -- To view, visit http://gerrit.cloudera.org:8080/24403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a84eacb66eb0a216bfb2159542a0d7e4ddf8ec2 Gerrit-Change-Number: 24403 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Thu, 04 Jun 2026 21:13:33 +0000 Gerrit-HasComments: Yes
