Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/24271 )
Change subject: IMPALA-14904: Calcite planner: Enable width_bucket function ...................................................................... Patch Set 1: (6 comments) Hi! I am still trying to understand the patch. http://gerrit.cloudera.org:8080/#/c/24271/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24271/1//COMMIT_MSG@50 PS1, Line 50: places that have been changed to handle this. Would it be better to add the paragraph as a comment or doc for the class? http://gerrit.cloudera.org:8080/#/c/24271/1//COMMIT_MSG@55 PS1, Line 55: Would it be better to add the paragraph as a comment or doc for the function? http://gerrit.cloudera.org:8080/#/c/24271/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java: http://gerrit.cloudera.org:8080/#/c/24271/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@363 PS1, Line 363: return ImpalaTypeConverter.getCompatibleType(ImmutableList.of(dt1, dt2), Could we remove the ImmutableList.of() call to simplify the code? http://gerrit.cloudera.org:8080/#/c/24271/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@499 PS1, Line 499: potentiall Seems like a typo? http://gerrit.cloudera.org:8080/#/c/24271/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java: http://gerrit.cloudera.org:8080/#/c/24271/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@352 PS1, Line 352: SqlOperator op It seems that we only need the kind of the SqlOperator in this function. Is that correct? http://gerrit.cloudera.org:8080/#/c/24271/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@352 PS1, Line 352: public static Type getCommonDecimalTypeToUse(SqlOperator op, List<RelDataType> argTypes, Could you explain what "common" means in the code? -- To view, visit http://gerrit.cloudera.org:8080/24271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2944fde1301e48b3fb0c29be7290b1ad9533e5b6 Gerrit-Change-Number: 24271 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 05 Jun 2026 06:19:03 +0000 Gerrit-HasComments: Yes
