Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24386 )
Change subject: IMPALA-14589: [Part 4] Add Iceberg V3 DDL support for column defaults ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24386/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24386/3//COMMIT_MSG@15 PS3, Line 15: If format-version is omitted but any column has : DEFAULT, Impala auto-sets format-version to 3. Outdated sentence http://gerrit.cloudera.org:8080/#/c/24386/3/fe/src/main/java/org/apache/impala/util/IcebergSchemaConverter.java File fe/src/main/java/org/apache/impala/util/IcebergSchemaConverter.java: http://gerrit.cloudera.org:8080/#/c/24386/3/fe/src/main/java/org/apache/impala/util/IcebergSchemaConverter.java@293 PS3, Line 293: return null; We could throw an exception for this case, like "Invalid empty literal for non-STRING type" -- To view, visit http://gerrit.cloudera.org:8080/24386 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibec771f324a0a9534e767e4b1fc66b25b41483ae Gerrit-Change-Number: 24386 Gerrit-PatchSet: 3 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 05 Jun 2026 13:18:11 +0000 Gerrit-HasComments: Yes
