Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24375 )
Change subject: IMPALA-14838: Count open deferred RPC intervals ...................................................................... IMPALA-14838: Count open deferred RPC intervals TotalHasDeferredRPCsTime was only updated when a sender queue drained its deferred RPC queue. If the queue was still non-empty when the profile was sampled, the counter stayed at zero even though RPCs had been deferred. Use RuntimeProfile::ConcurrentTimerCounter for TotalHasDeferredRPCsTime and start/stop it when a sender queue deferred RPC interval opens or closes. This keeps completed time and an open interval visible in the live profile while avoiding double-counting overlapping intervals across sender queues. Add a data-stream regression test that keeps the receiver reader stopped, waits until an RPC is deferred, and verifies that the live profile reports deferred RPC time before cancellation drains the queue. Testing: - git diff --check - data-stream-test Assisted-by: OpenAI Codex Change-Id: I5efe8016b268e3707a2b7b99c488de69ccdad8e6 Reviewed-on: http://gerrit.cloudera.org:8080/24375 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/data-stream-test.cc M be/src/runtime/krpc-data-stream-recvr.cc M be/src/runtime/krpc-data-stream-recvr.h 3 files changed, 69 insertions(+), 19 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5efe8016b268e3707a2b7b99c488de69ccdad8e6 Gerrit-Change-Number: 24375 Gerrit-PatchSet: 9 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
