Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24381 )
Change subject: IMPALA-12955: Split RuntimeProfile sources ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/24381/1/be/src/util/runtime-profile-archive.cc File be/src/util/runtime-profile-archive.cc: http://gerrit.cloudera.org:8080/#/c/24381/1/be/src/util/runtime-profile-archive.cc@39 PS1, Line 39: int32_t GetProfileVersion(const TRuntimeProfileTree& tree) { Why is this no longer a static function? http://gerrit.cloudera.org:8080/#/c/24381/1/be/src/util/runtime-profile-periodic.cc File be/src/util/runtime-profile-periodic.cc: http://gerrit.cloudera.org:8080/#/c/24381/1/be/src/util/runtime-profile-periodic.cc@33 PS1, Line 33: static const string ROOT_COUNTER = ""; This is now duplicated across the files. Is it still needed in the original? -- To view, visit http://gerrit.cloudera.org:8080/24381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If37aee20eb2dc4e9b140908543426860415cf306 Gerrit-Change-Number: 24381 Gerrit-PatchSet: 1 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 08 Jun 2026 16:31:01 +0000 Gerrit-HasComments: Yes
