Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21579 )
Change subject: IMPALA-15080: Add queuing to KrpcDataStreamSender ...................................................................... Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/21579/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21579/12//COMMIT_MSG@12 PS12, Line 12: 2. in-flight batch (with current active RPC) > in-flight is still missing a 't'. Done http://gerrit.cloudera.org:8080/#/c/21579/12/be/src/runtime/krpc-data-stream-sender.h File be/src/runtime/krpc-data-stream-sender.h: http://gerrit.cloudera.org:8080/#/c/21579/12/be/src/runtime/krpc-data-stream-sender.h@317 PS12, Line 317: // sending it (QueuedBatch::consumers_left reaches 0). > I thought about intrusive list, but since you're allocating QueuedBatch dir Tried to read about how big chunks does dequeue use, and it seems that on some platforms it's pretty big, and could waste some memory as most of the time the size of these queues should be 0-2. -- To view, visit http://gerrit.cloudera.org:8080/21579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe3d01fada31f1b48de6c1403e7d2955114d8078 Gerrit-Change-Number: 21579 Gerrit-PatchSet: 16 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 08 Jun 2026 17:55:11 +0000 Gerrit-HasComments: Yes
