Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 )
Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services ...................................................................... Patch Set 1: Some high level questions: 1. At what point do we want this checked in? 2.12.0 was the first release with KRPC and we've not gotten enough user feedback yet to know all the issues with the feature. Should we bite the bullet and deal with the issues as they come? Or should we leave Thrift RPC as a fallback for a while? 2. Should we rename all the KrpcDataStream* to DataStream* now since there's only one implementation now? Or should we keep a buffed period of releases before renaming to avoid confusion? 3. Was this patch mostly mechanical? Or did you face any issue(s) in getting rid of the flag and DataStream* classes? -- To view, visit http://gerrit.cloudera.org:8080/10835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfed200751508478a3d728a917448f2dabfc67c3 Gerrit-Change-Number: 10835 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Fri, 29 Jun 2018 16:29:05 +0000 Gerrit-HasComments: No
