Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24378 )
Change subject: IMPALA-14099: Tolerate large profile log timestamps ...................................................................... Patch Set 2: (1 comment) > Patch Set 2: Code-Review+1 > > (1 comment) http://gerrit.cloudera.org:8080/#/c/24378/2/tests/observability/test_profile_tool.py File tests/observability/test_profile_tool.py: http://gerrit.cloudera.org:8080/#/c/24378/2/tests/observability/test_profile_tool.py@127 PS2, Line 127: '174830243931748302879977 %s %s' % (fields[1], fields[2])) > This is presumably a timestamp with nanoseconds? I'd be interested in makin Thanks. The upstream profile log writer currently prefixes entries with UnixMillis(), so this oversized token does not look like the canonical profile-log timestamp format. I filed https://issues.apache.org/jira/browse/IMPALA-15081 to track improving timestamp filter handling separately. That can cover documenting the current epoch-milliseconds semantics, improving filter diagnostics, investigating where high-precision/non-canonical timestamp tokens come from, and possibly adding ISO-8601 or explicit timestamp-unit support. I’ll keep this patch focused on not rejecting the profile payload when timestamp filters are not requested. -- To view, visit http://gerrit.cloudera.org:8080/24378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2514011d61c4d79b501f52dc0b1c1fcf7b11b06 Gerrit-Change-Number: 24378 Gerrit-PatchSet: 2 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 08 Jun 2026 19:33:42 +0000 Gerrit-HasComments: Yes
