Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24414 )
Change subject: IMPALA-15078: Fix TSAN race in data-stream test ...................................................................... IMPALA-15078: Fix TSAN race in data-stream test The IMPALA-14838 regression test updated FLAGS_datastream_sender_timeout_ms after DataStreamTest::SetUp() had already started KrpcDataStreamMgr's maintenance thread. TSAN can report a race because Maintenance() reads the same flag concurrently. The longer early-sender timeout is unnecessary here because the test creates the receiver before starting the sender. Remove the flag update from the test body so the maintenance thread has no concurrent gflag writer. Testing: git diff --check Assisted-by: OpenAI Codex Change-Id: Ied81ad4660e8fb69a443f2c74c6fafc6c99c0c18 Reviewed-on: http://gerrit.cloudera.org:8080/24414 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/data-stream-test.cc 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ied81ad4660e8fb69a443f2c74c6fafc6c99c0c18 Gerrit-Change-Number: 24414 Gerrit-PatchSet: 3 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
