Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24376 )
Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift) ...................................................................... IMPALA-12696: Update HS2 definitions (TCLIService.thrift) Update to "fresh" (didn't change since 2022) TCLIService.thrift from Hive repo. Mainly a copy of Hive version, but some changes were needed: - change python namespace to impala_thrift_gen.TCLIService - reorder a few structs to avoid compilation errors in c++ - readd GetLog() Implements one of the new functions (GetQueryId) and returns "not implemented" error for others. Realized last minute that there is a very similar prototype review: https://gerrit.cloudera.org/#/c/20495/ My change does almost the same, but updates to a bit newer version and does not change server behavior, e.g. doesn't bump MAX_SUPPORTED_HS2_VERSION. The main motivation is providing the generated python artifacts for impyla which is also used with Hive. Using the new possibilites in the protocol could be done in follow up patches. Generated-by: Cloude Sonnet 4.6 Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc Reviewed-on: http://gerrit.cloudera.org:8080/24376 Reviewed-by: Impala Public Jenkins <[email protected]> Reviewed-by: Csaba Ringhofer <[email protected]> Tested-by: Csaba Ringhofer <[email protected]> --- M be/src/rpc/hs2-http-test.cc M be/src/service/impala-hs2-server.cc M be/src/service/impala-server.h M common/thrift/hive-1-api/TCLIService.thrift M tests/hs2/test_hs2.py 5 files changed, 261 insertions(+), 15 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved Csaba Ringhofer: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc Gerrit-Change-Number: 24376 Gerrit-PatchSet: 8 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
