Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24426 )
Change subject: [WIP] IMPALA-14601: HBO for computing JoinNode cardinality ...................................................................... Patch Set 1: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24426/1/fe/src/test/java/org/apache/impala/planner/JoinNodeHboTest.java File fe/src/test/java/org/apache/impala/planner/JoinNodeHboTest.java: http://gerrit.cloudera.org:8080/#/c/24426/1/fe/src/test/java/org/apache/impala/planner/JoinNodeHboTest.java@108 PS1, Line 108: String outerFilters = "where a.year=2009 and b.year=2009 and a.int_col=0 and b.int_col=0"; line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/24426/1/fe/src/test/java/org/apache/impala/planner/JoinNodeHboTest.java@112 PS1, Line 112: + "right anti join functional_parquet.alltypes a on b.id = a.id " + semiAntiFilters; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24426/1/fe/src/test/java/org/apache/impala/planner/JoinNodeHboTest.java@116 PS1, Line 116: + "right semi join functional_parquet.alltypes a on b.id = a.id " + semiAntiFilters; line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4 Gerrit-Change-Number: 24426 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2026 14:15:02 +0000 Gerrit-HasComments: Yes
