Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24392 )
Change subject: IMPALA-15067: Add VariantValue and basic decoding functions ...................................................................... Patch Set 3: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24392/3/be/src/runtime/variant-value.h File be/src/runtime/variant-value.h: http://gerrit.cloudera.org:8080/#/c/24392/3/be/src/runtime/variant-value.h@152 PS3, Line 152: // - For OBJECT: field_offset_size_minus_one (bits 2-3), field_id_size_minus_one (bits 4-5), line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/24392/3/be/src/util/variant-util-test.cc File be/src/util/variant-util-test.cc: http://gerrit.cloudera.org:8080/#/c/24392/3/be/src/util/variant-util-test.cc@459 PS3, Line 459: R"V({"context":{"page":"home","retries":3},"device":"mobile","int_array":[1,2,3,4,10],"user":"Alice"})V"}, line too long (111 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I904618570e8c21d099c9a96b496d85e9246483de Gerrit-Change-Number: 24392 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2026 15:49:41 +0000 Gerrit-HasComments: Yes
