Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24418 )
Change subject: IMPALA-15082: Add VSCode Settings and Launch Configs ...................................................................... Patch Set 3: > Patch Set 2: > > I think these configuration files should be a recommendation, not a mandatory > part of the repository. If this is checked in, most of our excluded configs > will be overridden by these configs. I think it's better to create a wiki > page that lists these configurations, or put them to a separate, non-clashing > folder structure. Also, these configs are notoriously rotting fast, so > updating them for everyone is painful, mostly when someone excluded them to > store custom settings to avoid being shown as unstaged changes. The goal is to reduce friction for Impala developers. I would prefer for the settings to be automatically available instead of having to be downloaded from a separate location. All the settings here should be applicable to all VSCode environments. Users desiring customizations can either define User level settings (which apply to all VSCode instances) or directly override/add settings in *.code-workspace files. Are there specific settings that could be modified/removed to make these settings work for everyone? -- To view, visit http://gerrit.cloudera.org:8080/24418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98e6966d83fdaaedda867a37b42725616d3b9216 Gerrit-Change-Number: 24418 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2026 19:31:11 +0000 Gerrit-HasComments: No
