Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22091 )

Change subject: IMPALA-13531: Calcite CTE frontend
......................................................................


Patch Set 28:

(7 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22091/28/fe/src/main/java/org/apache/impala/planner/SequenceNode.java
File fe/src/main/java/org/apache/impala/planner/SequenceNode.java:

http://gerrit.cloudera.org:8080/#/c/22091/28/fe/src/main/java/org/apache/impala/planner/SequenceNode.java@25
PS28, Line 25: import org.apache.impala.common.ImpalaException;
unused import: org.apache.impala.common.ImpalaException


http://gerrit.cloudera.org:8080/#/c/22091/28/fe/src/main/java/org/apache/impala/planner/SequenceNode.java@32
PS28, Line 32: import com.google.common.base.Preconditions;
unused import: com.google.common.base.Preconditions


http://gerrit.cloudera.org:8080/#/c/22091/28/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java
File 
java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java:

http://gerrit.cloudera.org:8080/#/c/22091/28/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@56
PS28, Line 56: import org.apache.impala.calcite.rules.CombineValuesNodesRule;
unused import: org.apache.impala.calcite.rules.CombineValuesNodesRule


http://gerrit.cloudera.org:8080/#/c/22091/28/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@58
PS28, Line 58: import org.apache.impala.calcite.rules.ExtractLiteralAgg;
unused import: org.apache.impala.calcite.rules.ExtractLiteralAgg


http://gerrit.cloudera.org:8080/#/c/22091/28/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@61
PS28, Line 61: import 
org.apache.impala.calcite.rules.ImpalaJoinProjectTransposeRule;
unused import: org.apache.impala.calcite.rules.ImpalaJoinProjectTransposeRule


http://gerrit.cloudera.org:8080/#/c/22091/28/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@62
PS28, Line 62: import org.apache.impala.calcite.rules.ImpalaMinusToDistinctRule;
unused import: org.apache.impala.calcite.rules.ImpalaMinusToDistinctRule


http://gerrit.cloudera.org:8080/#/c/22091/28/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@67
PS28, Line 67: import org.apache.impala.calcite.rules.RewriteRexOverRule;
unused import: org.apache.impala.calcite.rules.RewriteRexOverRule



--
To view, visit http://gerrit.cloudera.org:8080/22091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0840c0859d2fe25628d799a18d302cee1eb36e8
Gerrit-Change-Number: 22091
Gerrit-PatchSet: 28
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Tue, 09 Jun 2026 22:43:41 +0000
Gerrit-HasComments: Yes

Reply via email to