Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23866 )
Change subject: IMPALA-14681: Add Agent Instruction Files ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/23866/11/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/23866/11/buildall.sh@218 PS11, Line 218: -help|--help|*) > I think it's better to align the AGENTS.md for the codebase, than the other https://agentskills.io/skill-creation/using-scripts#document-usage-with-help says to document scripts with the `--help` flag. Since the spec specifically calls out that flag, agents are going to favor using it, and I think we should move towards using it (not to mention the Linux convention is to use two dashes for multi-character flags). I still need to add a details about buildall.sh to AGENTS.md though. -- To view, visit http://gerrit.cloudera.org:8080/23866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3063bcff29a97ac30770ae53febd53813a4974e9 Gerrit-Change-Number: 23866 Gerrit-PatchSet: 11 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2026 23:29:30 +0000 Gerrit-HasComments: Yes
