Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10810 )
Change subject: IMPALA-7095: clean up scan node profiles ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/10810/6/be/src/exec/scan-node.h File be/src/exec/scan-node.h: http://gerrit.cloudera.org:8080/#/c/10810/6/be/src/exec/scan-node.h@52 PS6, Line 52: TotalRawHdfsReadTime > This counter is in HdfsScanNodeBase. PerReadThreadRawHdfsThroughput and Num Reorganised to put the counters into the appropriate class comment. http://gerrit.cloudera.org:8080/#/c/10810/6/be/src/exec/scan-node.cc File be/src/exec/scan-node.cc: http://gerrit.cloudera.org:8080/#/c/10810/6/be/src/exec/scan-node.cc@222 PS6, Line 222: // faster producer. Also used for Kudu under the assumption that the scan runs co-located > Nit: too long line Done http://gerrit.cloudera.org:8080/#/c/10810/6/be/src/exec/scan-node.cc@247 PS6, Line 247: num_active > Nit: Since C++14 the lambda capture can be [&num_active = num_active_] and Done -- To view, visit http://gerrit.cloudera.org:8080/10810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77286282d42e7764bfdf94c7ec47cec9d743f787 Gerrit-Change-Number: 10810 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 29 Jun 2018 22:17:14 +0000 Gerrit-HasComments: Yes
