Stamatis Zampetakis has posted comments on this change. ( http://gerrit.cloudera.org:8080/24229 )
Change subject: IMPALA-14916: Display Calcite plan in EXPLAIN output ...................................................................... Patch Set 3: (3 comments) Rebased, resolved conflicts, and addressed review comments. Please take another look once you get a chance. http://gerrit.cloudera.org:8080/#/c/24229/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24229/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-14916: Display Calcite plan in EXPLAIN output > Let's confine this to one ticket. This set of changes seems fine as a singl I uploaded a new patch and modified the commit message to mention only IMPALA-14916 http://gerrit.cloudera.org:8080/#/c/24229/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlannerIntf.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlannerIntf.java: http://gerrit.cloudera.org:8080/#/c/24229/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlannerIntf.java@49 PS1, Line 49: /** > nit: would look nicer with a comment describing what the function should do Indeed, I forgot about that. In the second patch I added some Javadoc. http://gerrit.cloudera.org:8080/#/c/24229/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/24229/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@60 PS1, Line 60: private RelNode finalPlan_; > Will fix this once we agree on everything else so I don't update the reques Renamed in the second patch. -- To view, visit http://gerrit.cloudera.org:8080/24229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec51e2b4315e95020e1826acfa477aaea4c45601 Gerrit-Change-Number: 24229 Gerrit-PatchSet: 3 Gerrit-Owner: Stamatis Zampetakis <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Stamatis Zampetakis <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 10 Jun 2026 19:16:46 +0000 Gerrit-HasComments: Yes
