Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24358 )
Change subject: IMPALA-12955: Slim down profile tool deps ...................................................................... IMPALA-12955: Slim down profile tool deps Use the RuntimeProfile source split from the parent change to link impala-profile-tool against smaller dependency subsets. The tool no longer pulls in unused runtime libraries such as HDFS, JVM, Kudu, SASL, Kerberos, SSL, and crypto dependencies. The profile tool now links ProfileToolThrift, ProfileToolUtil, and StatusMinimal. Keep CMake source lists shared with the full targets to avoid drift, and keep StatusMinimal in the global Impala link group so normal backend binaries do not depend on transitive link ordering. Move GetStackTrace() into util/stack-trace.* so StatusMinimal and Util can share it without linking debug-util.cc into the profile tool. Move Status thrift/proto/HS2 conversions out of the Status class into status-serialization.* free functions. The archive reader uses local base64 length validation, base64 unescaping, zlib inflate, and local thrift deserialization to avoid pulling coding-util.cc and thrift-util.cc dependencies into the profile tool. Error messages distinguish invalid base64 length from invalid base64 data. The Linux dependency test checks both direct NEEDED entries and transitive ldd output so regressions through shared helper libraries are caught. Tests: - git diff --check - python3 -m py_compile \ tests/observability/test_profile_tool_dependencies.py - ./buildall.sh -notests -noclean -cmake_only - make -C be/src/util impala-profile-tool -j 64 - make Catalog Runtime Exec Scheduling Service Statestore -j 64 - bin/create-test-configuration.sh - bin/impala-py.test -q tests/observability/test_profile_tool.py - ./buildall.sh -release -so -notests -noclean -cmake_only - make -C be/src/util impala-profile-tool -j 64 - be/build/latest/util/impala-profile-tool --help - bin/impala-py.test -q \ tests/observability/test_profile_tool_dependencies.py Assisted-by: OpenAI Codex Change-Id: Id476411dcf6c46079e2e2addc5cdd552bc23f8a1 Reviewed-on: http://gerrit.cloudera.org:8080/24358 Reviewed-by: Michael Smith <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/CMakeLists.txt M be/generated-sources/gen-cpp/CMakeLists.txt M be/src/catalog/catalog-server.cc M be/src/catalog/workload-management-init.cc M be/src/common/CMakeLists.txt A be/src/common/status-serialization.cc A be/src/common/status-serialization.h M be/src/common/status.cc M be/src/common/status.h M be/src/exec/catalog-op-executor.cc M be/src/exec/data-source-scan-node.cc M be/src/runtime/coordinator-backend-state.cc M be/src/runtime/krpc-data-stream-sender.cc M be/src/runtime/mem-pool.h M be/src/runtime/query-state.cc M be/src/runtime/runtime-filter-bank.cc A be/src/runtime/summary-stats.h M be/src/scheduling/admission-control-service.cc M be/src/scheduling/remote-admission-control-client.cc M be/src/service/child-query.cc M be/src/service/client-request-state.cc M be/src/service/control-service.cc M be/src/service/data-stream-service.cc M be/src/service/fe-support.cc M be/src/service/impala-beeswax-server.cc M be/src/service/impala-server.cc M be/src/statestore/statestore-subscriber.cc M be/src/statestore/statestore.cc M be/src/util/CMakeLists.txt M be/src/util/debug-util.cc M be/src/util/debug-util.h A be/src/util/error-msg.cc M be/src/util/error-util.cc M be/src/util/runtime-profile-archive.cc M be/src/util/runtime-profile.cc A be/src/util/stack-trace.cc A be/src/util/stack-trace.h A tests/observability/test_profile_tool_dependencies.py 38 files changed, 738 insertions(+), 396 deletions(-) Approvals: Michael Smith: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/24358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id476411dcf6c46079e2e2addc5cdd552bc23f8a1 Gerrit-Change-Number: 24358 Gerrit-PatchSet: 13 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]>
