Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24437 )
Change subject: IMPALA-14182: Deflake test_breakpad.py's TestLogging* tests ...................................................................... IMPALA-14182: Deflake test_breakpad.py's TestLogging* tests These tests have been flaky with two types of error: - Exceeding the max expected log files - Exceeding the max expected log file size This relaxes those two checks: - The enforcement of the max log files is done by a background thread, and it can briefly exceed the number of log files. This should be limited to a single log file per severity level. This adjusts the max log file calculation to allow for an extra log file per severity level. - This increases the max log file size from 1.2MB to 1.3MB. This also changes the tests to preserve the logs if hitting any of these asserts. This should make it easier to tell what is happening if this reoccurs. Testing: - Ran TestLogging/TestLoggingExhaustive locally - Forced a failure and verified that the logs are preserved Change-Id: I79f97ca26320369ebb53f7f57e6c86e912c9cf02 Reviewed-on: http://gerrit.cloudera.org:8080/24437 Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Csaba Ringhofer <[email protected]> Tested-by: Joe McDonnell <[email protected]> --- M tests/common/custom_cluster_test_suite.py M tests/custom_cluster/test_breakpad.py 2 files changed, 70 insertions(+), 27 deletions(-) Approvals: Michael Smith: Looks good to me, but someone else must approve Csaba Ringhofer: Looks good to me, approved Joe McDonnell: Verified -- To view, visit http://gerrit.cloudera.org:8080/24437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I79f97ca26320369ebb53f7f57e6c86e912c9cf02 Gerrit-Change-Number: 24437 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
