Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24451 )

Change subject: IMPALA-15097: Show runtime filter effectiveness in plan graph
......................................................................


Patch Set 1:

(6 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24451/1/tests/unittests/test_plan_graph.py
File tests/unittests/test_plan_graph.py:

http://gerrit.cloudera.org:8080/#/c/24451/1/tests/unittests/test_plan_graph.py@82
PS1, Line 82: S
flake8: E501 line too long (91 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/24451/1/tests/unittests/test_plan_graph.py@84
PS1, Line 84: +
flake8: W504 line break after binary operator


http://gerrit.cloudera.org:8080/#/c/24451/1/tests/unittests/test_plan_graph.py@87
PS1, Line 87: +
flake8: W504 line break after binary operator


http://gerrit.cloudera.org:8080/#/c/24451/1/tests/unittests/test_plan_graph.py@102
PS1, Line 102: t
flake8: E501 line too long (109 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/24451/1/tests/unittests/test_plan_graph.py@104
PS1, Line 104:
flake8: E501 line too long (104 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/24451/1/tests/unittests/test_plan_graph.py@105
PS1, Line 105:
flake8: E501 line too long (104 > 90 characters)



--
To view, visit http://gerrit.cloudera.org:8080/24451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic61ba09b9977da4545f3bfd1489e0856a7c0af40
Gerrit-Change-Number: 24451
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Fri, 12 Jun 2026 12:45:41 +0000
Gerrit-HasComments: Yes

Reply via email to