Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24395 )
Change subject: IMPALA-14526: [DOCS] Documentation for OpenTelemetry Integration ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/24395/1/docs/impala.ditamap File docs/impala.ditamap: http://gerrit.cloudera.org:8080/#/c/24395/1/docs/impala.ditamap@76 PS1, Line 76: <topicref audience="integrated" href="topics/impala_opentelemetry_support.xml"> : <topicref audience="integrated" href="topics/impala_opentelemetry_data_collector.xml"/> : </topicref> Remove `audience="integrated"` from both `<topicref>` tags and move these 3 lines to be under line 73. http://gerrit.cloudera.org:8080/#/c/24395/1/docs/topics/impala_opentelemetry_data_collector.xml File docs/topics/impala_opentelemetry_data_collector.xml: http://gerrit.cloudera.org:8080/#/c/24395/1/docs/topics/impala_opentelemetry_data_collector.xml@300 PS1, Line 300: <section> The formatting of having these child spans in their own section is confusing since the Init child span is under the "Child Spans" section. http://gerrit.cloudera.org:8080/#/c/24395/1/docs/topics/impala_opentelemetry_support.xml File docs/topics/impala_opentelemetry_support.xml: http://gerrit.cloudera.org:8080/#/c/24395/1/docs/topics/impala_opentelemetry_support.xml@36 PS1, Line 36: <p> OpenTelemetry (OTel) provides an open-source solution for collecting, processing, and : exporting telemetry data, including metrics from applications. OTel helps users gain : visibility into query performance and troubleshoot query failures. OpenTelemetry (OTel) is : supported with <keyword keyref="impala50"/>.</p> Impala does not currently support sending metrics via OTel. Let's just link to https://opentelemetry.io/ here. http://gerrit.cloudera.org:8080/#/c/24395/1/docs/topics/impala_opentelemetry_support.xml@99 PS1, Line 99: Jaeger, Zipkin, Prometheus and Grafana Since Impala does not support sending metrics, let's not mention Prometheus and Grafana. Instead let's say "have your own instances of Jaeger, Zipkin, or other trace visualization system". http://gerrit.cloudera.org:8080/#/c/24395/1/docs/topics/impala_opentelemetry_support.xml@160 PS1, Line 160: <dd>Select queries that leverage Common Table Expressions will not have traces generated : for them.</dd> This statement is incorrect. Please remove it. -- To view, visit http://gerrit.cloudera.org:8080/24395 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0e6d25a53fe2214944840bf5c6a877640ef8316 Gerrit-Change-Number: 24395 Gerrit-PatchSet: 1 Gerrit-Owner: Sanjana Malhotra <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Sanjana Malhotra <[email protected]> Gerrit-Comment-Date: Fri, 12 Jun 2026 18:04:00 +0000 Gerrit-HasComments: Yes
