Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/24325 )
Change subject: IMPALA-15013: Fix NULL issues for PIVOT ...................................................................... Patch Set 10: (2 comments) > Patch Set 8: Code-Review+1 > > (2 comments) > > The fix looks good to me. Just have some minor comments on missing test > coverage. I can bump my vote up after they are addressed. Thanks for your reviews! http://gerrit.cloudera.org:8080/#/c/24325/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/24325/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@522 PS3, Line 522: "Duplicate alias for aggregations in the PIVOT clause: min" > Can we keep this test? We don't have test coverage on such case. Thanks! It seems that ndv_no_finalize() cannot trigger the error now. http://gerrit.cloudera.org:8080/#/c/24325/3/testdata/workloads/functional-query/queries/QueryTest/pivot-clause.test File testdata/workloads/functional-query/queries/QueryTest/pivot-clause.test: http://gerrit.cloudera.org:8080/#/c/24325/3/testdata/workloads/functional-query/queries/QueryTest/pivot-clause.test@466 PS3, Line 466: ==== > Can we add a test case like this? Thanks! Added. -- To view, visit http://gerrit.cloudera.org:8080/24325 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idae4a510dd3d6c4cd16a3e03aa0161ad84863e5a Gerrit-Change-Number: 24325 Gerrit-PatchSet: 10 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Mon, 15 Jun 2026 03:36:52 +0000 Gerrit-HasComments: Yes
