Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/24153 )
Change subject: IMPALA-14597: Initial HBO support ...................................................................... Patch Set 21: Code-Review+2 (2 comments) This is looking good overall. Carry forward previous +1s from reviewers and bumping mine to +2. http://gerrit.cloudera.org:8080/#/c/24153/17/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java File fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java: http://gerrit.cloudera.org:8080/#/c/24153/17/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java@56 PS17, Line 56: public static List<String> canonicalizeScanConjuncts(List<Expr> exprs, FeTable table, > Yeah, the cost should be considered. Currently we just deal with some simpl Done http://gerrit.cloudera.org:8080/#/c/24153/17/testdata/workloads/functional-query/queries/QueryTest/hbo-collection-scan.test File testdata/workloads/functional-query/queries/QueryTest/hbo-collection-scan.test: http://gerrit.cloudera.org:8080/#/c/24153/17/testdata/workloads/functional-query/queries/QueryTest/hbo-collection-scan.test@1 PS17, Line 1: ==== > That's a good point. Added hbo-disjunct-selectivity.test for this. Done -- To view, visit http://gerrit.cloudera.org:8080/24153 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ff60a8bd22c13c0ecad1198934cc96249b1015e Gerrit-Change-Number: 24153 Gerrit-PatchSet: 21 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Mon, 15 Jun 2026 03:42:14 +0000 Gerrit-HasComments: Yes
