Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23732 )
Change subject: IMPALA-14594: Scale grouping aggregator's input cardinality by the number of backends ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23732/2/be/src/exec/aggregation-node-base.cc File be/src/exec/aggregation-node-base.cc: http://gerrit.cloudera.org:8080/#/c/23732/2/be/src/exec/aggregation-node-base.cc@101 PS2, Line 101: estimated_input_cardinality = agg_node.estimated_input_cardinality / num_backends_; Should we also divide this by mt_dop when mt_dop > 1? When COMPUTE_PROCESSING_COST is enabled, we might need to use the number of instances. FE has some similar codes: https://github.com/apache/impala/blob/c8ec628c5ddc32b68842b8038522c587f313f277/fe/src/main/java/org/apache/impala/planner/AggregationNode.java#L1000-L1001 -- To view, visit http://gerrit.cloudera.org:8080/23732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf66709f12ea9b7328ca4e4c5cd45a05c9dc3032 Gerrit-Change-Number: 23732 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 15 Jun 2026 08:40:03 +0000 Gerrit-HasComments: Yes
