Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24297 )

Change subject: IMPALA-14600: Support HBO for AggregationNode cardinality
......................................................................


Patch Set 5:

(3 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24297/5/fe/src/main/java/org/apache/impala/planner/AggregationNode.java
File fe/src/main/java/org/apache/impala/planner/AggregationNode.java:

http://gerrit.cloudera.org:8080/#/c/24297/5/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@792
PS5, Line 792:    *
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/24297/5/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@795
PS5, Line 795:    *
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/24297/5/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java
File fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java:

http://gerrit.cloudera.org:8080/#/c/24297/5/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java@34
PS5, Line 34: import static org.junit.Assert.assertTrue;
unused import: org.junit.Assert.assertTrue



--
To view, visit http://gerrit.cloudera.org:8080/24297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0fafaf9d827f3bf533b1af7e62fdb2303c126ce
Gerrit-Change-Number: 24297
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Mon, 15 Jun 2026 15:03:53 +0000
Gerrit-HasComments: Yes

Reply via email to