Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24457 )
Change subject: IMPALA-14787: Add support for Redhat 10 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24457/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24457/1//COMMIT_MSG@36 PS1, Line 36: This patches GCC with the fix from GCC 12: > Moving to GCC 12 is not hard. If we have any need for it, I can do it now. I would prefer bumping GCC instead of patching old version, but I can't say that I "need" it. Based on my understanding the following could be good addition: - better c++20 support, which could help if we import libs that actually need c++20 - better constexpr handling, for example std::string can be constexpr + hopefully they improved compile time or create more efficient binaries -- To view, visit http://gerrit.cloudera.org:8080/24457 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c965c0e262113df6320e46f2bb793afa16bda30 Gerrit-Change-Number: 24457 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 15 Jun 2026 18:38:09 +0000 Gerrit-HasComments: Yes
