Csaba Ringhofer has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/24132 )
Change subject: IMPALA-14851: Codegen GroupingAggregator::CopyGroupingValues
......................................................................
IMPALA-14851: Codegen GroupingAggregator::CopyGroupingValues
Created codegen for GroupingAggregator::CopyGroupingValues.
This function runs when a new, distinct value is seen during a group by
aggregation.
Measurements:
Measured using the following:
set num_nodes=1; set mt_dop=1;
SELECT COUNT(DISTINCT l_orderkey, l_comment) FROM tpch.lineitem;
AGGREGATION_NODE Avg Time changed from 743.281ms to 659.414ms.
Codegen:
Before:
NumInstructions: 1.42K (1422)
NumOptimizedInstructions: 931 (931)
ModuleBitcodeSize: 3.67 MB (3846476)
After:
NumInstructions: 1.54K (1541)
NumOptimizedInstructions: 1.05K (1047)
ModuleBitcodeSize: 3.42 MB (3590728)
Testing:
Ran existing exhaustive and ASAN tests with patch.
Change-Id: Ia2c54a5745ba05a926795318d3b074fde6d0c00a
Reviewed-on: http://gerrit.cloudera.org:8080/24132
Reviewed-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Csaba Ringhofer <[email protected]>
Tested-by: Csaba Ringhofer <[email protected]>
---
M be/src/codegen/gen_ir_descriptions.py
M be/src/codegen/llvm-codegen.h
M be/src/exec/grouping-aggregator-ir.cc
M be/src/exec/grouping-aggregator.cc
M be/src/exec/grouping-aggregator.h
M be/src/runtime/descriptors.cc
M be/src/runtime/descriptors.h
7 files changed, 230 insertions(+), 70 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved
Csaba Ringhofer: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/24132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2c54a5745ba05a926795318d3b074fde6d0c00a
Gerrit-Change-Number: 24132
Gerrit-PatchSet: 13
Gerrit-Owner: Balazs Hevele <[email protected]>
Gerrit-Reviewer: Balazs Hevele <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
