Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24474 )
Change subject: IMPALA-13870: Add operator<< for StringVal to prevent unsafe ptr usage ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24474/2/be/src/exprs/ai-functions.cc File be/src/exprs/ai-functions.cc: http://gerrit.cloudera.org:8080/#/c/24474/2/be/src/exprs/ai-functions.cc@130 PS2, Line 130: << string(reinterpret_cast<const char*>(options.ptr), options.len) > Shall I implement that method, or can we leave that for a follow-up patch? We build with C++17. I guess I'm not sure whether our UDFs also require that. It can be a separate patch. -- To view, visit http://gerrit.cloudera.org:8080/24474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dd226d69fee428b5b38bdbf84dc73de4293c81b Gerrit-Change-Number: 24474 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 16 Jun 2026 17:29:45 +0000 Gerrit-HasComments: Yes
