Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24459 )

Change subject: IMPALA-14787: Add support for Redhat 10 and SLES 16
......................................................................


Patch Set 11: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24459/11//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24459/11//COMMIT_MSG@10
PS11, Line 10: JDK 21 and above in the package
             :    repositories. This defaults to JDK 21 for Redhat 10,
             :    which doesn't seem to introduce any issues.
IMO JDK 21 would worth its own epic that could be mentioned here.


http://gerrit.cloudera.org:8080/#/c/24459/11/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/24459/11/bin/bootstrap_system.sh@249
PS11, Line 249: redhat8 sudo yum install -y nscd
              : redhat9 sudo yum install -y nscd
nit: maybe it would be easier to maintain if we had functions like redhat8to9 
and redhat9to10 to avoid duplications?



--
To view, visit http://gerrit.cloudera.org:8080/24459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50acc5fbb4968e4310c4f84dde1d5b931b0385ec
Gerrit-Change-Number: 24459
Gerrit-PatchSet: 11
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Wed, 17 Jun 2026 12:28:48 +0000
Gerrit-HasComments: Yes

Reply via email to