Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10851 )
Change subject: IMPALA-6352: Dump backtrace on failure of TestTableSample ...................................................................... Patch Set 1: (3 comments) The approach seems good, just a few comments on naming http://gerrit.cloudera.org:8080/#/c/10851/1/tests/beeswax/impala_beeswax.py File tests/beeswax/impala_beeswax.py: http://gerrit.cloudera.org:8080/#/c/10851/1/tests/beeswax/impala_beeswax.py@370 PS1, Line 370: wait_for_completion_timeout Maybe this should be wait_for_finished, since the query isn't really "complete" in any meaningful sense. Same applies to the above method. http://gerrit.cloudera.org:8080/#/c/10851/1/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/10851/1/tests/common/impala_connection.py@182 PS1, Line 182: def wait_for_completion_timeout(self, operation_handle, timeout): Same comment http://gerrit.cloudera.org:8080/#/c/10851/1/tests/query_test/test_tablesample.py File tests/query_test/test_tablesample.py: http://gerrit.cloudera.org:8080/#/c/10851/1/tests/query_test/test_tablesample.py@63 PS1, Line 63: timed_out Isn't this the opposite of timed out? I.e. True means success, False means it timed out. -- To view, visit http://gerrit.cloudera.org:8080/10851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73fcdd30863cee105584c947bb0c48cf872809c1 Gerrit-Change-Number: 10851 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 02 Jul 2018 21:42:57 +0000 Gerrit-HasComments: Yes
