Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10704 )
Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/10704/11/tests/query_test/test_rows_availability.py File tests/query_test/test_rows_availability.py: http://gerrit.cloudera.org:8080/#/c/10704/11/tests/query_test/test_rows_availability.py@109 PS11, Line 109: matches = re.findall(r'([0-9]+h)?([0-9]+m)?([0-9]+s)?([0-9]+(\.[0-9]+)?ms)?([0-9]+(\.[0-9]+)?ns)?', nit: long line http://gerrit.cloudera.org:8080/#/c/10704/11/tests/query_test/test_rows_availability.py@127 PS11, Line 127: if matches[0][4]: : # Truncate fractional nanoseconds. : nanoseconds = int(float(matches[0][4][:-2])) : # Truncate nanoseconds to milliseconds. : milliseconds = nanoseconds / 1000 i think we can do away with not parsing this here since the method only returns a value with millisecond precision. Just the line at L109 should be sufficient to avoid failure -- To view, visit http://gerrit.cloudera.org:8080/10704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d6c26d42db090c8a15c602f6419ad6399c329e7 Gerrit-Change-Number: 10704 Gerrit-PatchSet: 11 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 02 Jul 2018 21:50:50 +0000 Gerrit-HasComments: Yes
