Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24448 )
Change subject: IMPALA-14799: Add oauth_servers support and tests ...................................................................... Patch Set 10: (7 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24448/10/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/24448/10/be/src/service/impala-server.cc@3237 PS10, Line 3237: const bool require_oauth_servers = (FLAGS_jwt_token_auth && FLAGS_jwt_validate_signature) line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24448/10/be/src/util/jwt-util.cc File be/src/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/24448/10/be/src/util/jwt-util.cc@784 PS10, Line 784: jwks_ca_certificate, current_jwks_checksum_, &is_changed, jwks_pull_timeout_secs_); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24448/10/be/src/util/oauth-server-config-test.cc File be/src/util/oauth-server-config-test.cc: http://gerrit.cloudera.org:8080/#/c/24448/10/be/src/util/oauth-server-config-test.cc@136 PS10, Line 136: TEST(OAuthServerConfigTest, BuildOAuthServerConfigsMergesLegacyJwtFlagsFromUsernameClaim) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24448/10/be/src/util/oauth-server-config-test.cc@189 PS10, Line 189: R"([{"jwksUrl":"https://example.com/oauth-servers-jwks.json","usernameClaim":"sub"}])"; line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24448/10/be/src/util/oauth-server-config.cc File be/src/util/oauth-server-config.cc: http://gerrit.cloudera.org:8080/#/c/24448/10/be/src/util/oauth-server-config.cc@138 PS10, Line 138: Status ParseOAuthServerObject(const rapidjson::Value& obj, OAuthServerConfig* config_out) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24448/10/be/src/util/oauth-server-config.cc@145 PS10, Line 145: RETURN_IF_ERROR(ReadOptionalStringField(obj, "caCertFilePath", &config.ca_cert_file_path)); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24448/10/be/src/util/oauth-server-config.cc@146 PS10, Line 146: RETURN_IF_ERROR(ReadOptionalBoolField(obj, "verifyServerCert", &config.verify_server_cert)); line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib29ff36600406ba59c10f29d79cc632020f4a3f7 Gerrit-Change-Number: 24448 Gerrit-PatchSet: 10 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Thu, 18 Jun 2026 09:22:19 +0000 Gerrit-HasComments: Yes
