Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/23866 )
Change subject: IMPALA-14681: Add Agent Instruction Files ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/23866/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23866/15//COMMIT_MSG@17 PS15, Line 17: critque nit: typo http://gerrit.cloudera.org:8080/#/c/23866/15/.agents/skills/build-one-cc-file/scripts/omake.sh File .agents/skills/build-one-cc-file/scripts/omake.sh: http://gerrit.cloudera.org:8080/#/c/23866/15/.agents/skills/build-one-cc-file/scripts/omake.sh@33 PS15, Line 33: .cc I am a bit confused about the example here, or maybe I'm missing something. Both the usage help and the agent skill file says that the script should be called with the basename of the source file to be checked (i.e. no extension should be supplied), while the example here specifies the .cc extension. I understand that the script is robust in this regard, and just strips the extension in case it's present, but I think the example would be less ambiguous without the extension. -- To view, visit http://gerrit.cloudera.org:8080/23866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3063bcff29a97ac30770ae53febd53813a4974e9 Gerrit-Change-Number: 23866 Gerrit-PatchSet: 15 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 19 Jun 2026 12:21:34 +0000 Gerrit-HasComments: Yes
