Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24416 )
Change subject: IMPALA-15079: Cleanup Open/Close locking in SharedJdbcConnection ...................................................................... Patch Set 2: Code-Review+2 (1 comment) One nit comment, otherwise LGTM! http://gerrit.cloudera.org:8080/#/c/24416/2/be/src/exec/data-source-scan-node.cc File be/src/exec/data-source-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/24416/2/be/src/exec/data-source-scan-node.cc@108 PS2, Line 108: wait for the first caller to finish nit: it's a bit odd sentence here, as at this point the caller has already waited. Maybe: // Subsequent callers: the first caller has already finished, use the initialized scan handle. -- To view, visit http://gerrit.cloudera.org:8080/24416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9f5c4ac71031b74b51bfa27ed04be10ed92e222 Gerrit-Change-Number: 24416 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 19 Jun 2026 12:45:29 +0000 Gerrit-HasComments: Yes
