Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24392 )
Change subject: IMPALA-15067: Add VariantValue and basic decoding functions ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24392/5/be/src/runtime/variant-value.cc File be/src/runtime/variant-value.cc: http://gerrit.cloudera.org:8080/#/c/24392/5/be/src/runtime/variant-value.cc@605 PS5, Line 605: // We need this local constexpr to avoid a linker error. Just C++ things. nit: the "Just C++ things" part sounds odd. Also, it can be avoided by using a ternary: size_t capacity = expected_size > rapidjson::StringBuffer::kDefaultCapacity ? expected_size : rapidjson::StringBuffer::kDefaultCapacity; http://gerrit.cloudera.org:8080/#/c/24392/5/be/src/runtime/variant-value.cc@614 PS5, Line 614: buffer.Reserve(Len() * 2); This is a noop as it's already sized for Len()*2 -- To view, visit http://gerrit.cloudera.org:8080/24392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I904618570e8c21d099c9a96b496d85e9246483de Gerrit-Change-Number: 24392 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 22 Jun 2026 08:15:48 +0000 Gerrit-HasComments: Yes
