Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24049 )
Change subject: POC IMPALA-14805: LocalIcebergTable loads files in coordinator ...................................................................... Patch Set 12: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24049/12/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/24049/12/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@473 PS12, Line 473: table.setIceberg_table(Utils.getTIcebergTable(this, ThriftObjectType.DESCRIPTOR_ONLY)); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24049/12/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@933 PS12, Line 933: LOG.trace("partIds size: {} want_iceberg_table: {} want_partition_files: {} want_partition_metadata: {} want_partition_names: {} want_partition_stats {} want_table_constraints{}", line too long (183 > 90) http://gerrit.cloudera.org:8080/#/c/24049/12/fe/src/main/java/org/apache/impala/catalog/local/IcebergMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/IcebergMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/24049/12/fe/src/main/java/org/apache/impala/catalog/local/IcebergMetaProvider.java@595 PS12, Line 595: oldFileStore == null ? Collections.emptyList() : oldFileStore.getPartitionList(), line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6732af76a2e040fa57e39260302951466037b934 Gerrit-Change-Number: 24049 Gerrit-PatchSet: 12 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 22 Jun 2026 08:26:09 +0000 Gerrit-HasComments: Yes
