Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24403 )
Change subject: IMPALA-14702: Add ability to build against Google Tcmalloc ...................................................................... Patch Set 9: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24403/9/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/24403/9/be/src/common/global-flags.cc@130 PS9, Line 130: googletcmalloc_max_per_cpu_cache_size Wouldn't it be better to get a total in the flag and divide it with the number of CPUs, so that it would work like tcmalloc_max_total_thread_cache_bytes? It would be easier to ensure things like "switching to google tcmalloc won't use more memory forthis than gperftools". http://gerrit.cloudera.org:8080/#/c/24403/9/bin/run-binary.sh File bin/run-binary.sh: http://gerrit.cloudera.org:8080/#/c/24403/9/bin/run-binary.sh@28 PS9, Line 28: # glibc's RSEQ functionality. https://github.com/google/tcmalloc/issues/144 could be mentioned - maybe one day they will learn to live together -- To view, visit http://gerrit.cloudera.org:8080/24403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a84eacb66eb0a216bfb2159542a0d7e4ddf8ec2 Gerrit-Change-Number: 24403 Gerrit-PatchSet: 9 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 23 Jun 2026 14:49:35 +0000 Gerrit-HasComments: Yes
