Peter Rozsa has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24418 )

Change subject: IMPALA-15082: Add VSCode Settings and Launch Configs
......................................................................


Patch Set 7: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24418/7/.vscode-defaults/settings.json
File .vscode-defaults/settings.json:

http://gerrit.cloudera.org:8080/#/c/24418/7/.vscode-defaults/settings.json@32
PS7, Line 32:     {
            :       "default": true,
            :       "name": "JavaSE-17",
            :       "path": "/usr/lib/jvm/java-17-openjdk-amd64"
            :     }
Is this always there? Is there another way to reference it via an env variable?


http://gerrit.cloudera.org:8080/#/c/24418/7/.vscode-defaults/settings.json@88
PS7, Line 88: /usr/local/bin/mvn
We ship a specific maven for Impala, it could be referenced here



--
To view, visit http://gerrit.cloudera.org:8080/24418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98e6966d83fdaaedda867a37b42725616d3b9216
Gerrit-Change-Number: 24418
Gerrit-PatchSet: 7
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Xuebin Su <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Tue, 23 Jun 2026 15:00:44 +0000
Gerrit-HasComments: Yes

Reply via email to