Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24494 )
Change subject: IMPALA-15114: Remove ehcache ...................................................................... Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/24494/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24494/1//COMMIT_MSG@10 PS1, Line 10: on older Javas. As impala bumped to Java 17 as minumum ehcache became typo: minimum http://gerrit.cloudera.org:8080/#/c/24494/1/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/24494/1/be/src/common/init.cc@401 PS1, Line 401: DCHECK_GE(version, 17) << "Unsupported Java version: " << version; nit: I don't think there's a problem using jamm for older releases. However the code to fetch and print Java version existed before IMPALA-11941, so we probably want to keep that around. -- To view, visit http://gerrit.cloudera.org:8080/24494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0122b74042acd6579bc98bbdc796c511bc54f0e5 Gerrit-Change-Number: 24494 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 23 Jun 2026 15:58:15 +0000 Gerrit-HasComments: Yes
