Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23848 )

Change subject: IMPALA-14942: [tools] Impala devcontainer
......................................................................


Patch Set 26:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23848/26/.devcontainer/set-tz-locale.sh
File .devcontainer/set-tz-locale.sh:

http://gerrit.cloudera.org:8080/#/c/23848/26/.devcontainer/set-tz-locale.sh@29
PS26, Line 29:   echo "[INFO] No timezone file found at 
'/.impala-devcontainer-tz'. Skipping timezone configuration."
line too long (102 > 90)


http://gerrit.cloudera.org:8080/#/c/23848/26/.devcontainer/set-tz-locale.sh@37
PS26, Line 37:   echo "[INFO] No locale file found at 
'/.impala-devcontainer-locale'. Skipping locale configuration."
line too long (102 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/23848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aa834494003619fcdfbd98f3bfc7c74d3e1554c
Gerrit-Change-Number: 23848
Gerrit-PatchSet: 26
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Wed, 24 Jun 2026 19:10:31 +0000
Gerrit-HasComments: Yes

Reply via email to