Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24211 )
Change subject: IMPALA-14909: Calcite planner: Fix validation for views with column list ...................................................................... Patch Set 7: (10 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24211/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteDb.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteDb.java: http://gerrit.cloudera.org:8080/#/c/24211/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteDb.java@30 PS7, Line 30: import org.apache.impala.calcite.type.ImpalaTypeSystemImpl; unused import: org.apache.impala.calcite.type.ImpalaTypeSystemImpl http://gerrit.cloudera.org:8080/#/c/24211/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteDb.java@38 PS7, Line 38: import java.lang.reflect.Type; unused import: java.lang.reflect.Type http://gerrit.cloudera.org:8080/#/c/24211/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaViewTable.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaViewTable.java: http://gerrit.cloudera.org:8080/#/c/24211/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaViewTable.java@27 PS7, Line 27: import org.apache.calcite.rel.type.RelDataType; unused import: org.apache.calcite.rel.type.RelDataType http://gerrit.cloudera.org:8080/#/c/24211/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java: http://gerrit.cloudera.org:8080/#/c/24211/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@51 PS7, Line 51: import org.apache.impala.common.ParseException; unused import: org.apache.impala.common.ParseException http://gerrit.cloudera.org:8080/#/c/24211/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java: http://gerrit.cloudera.org:8080/#/c/24211/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@25 PS7, Line 25: import org.apache.calcite.sql.type.SqlTypeName; unused import: org.apache.calcite.sql.type.SqlTypeName http://gerrit.cloudera.org:8080/#/c/24211/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@37 PS7, Line 37: import org.apache.calcite.sql.validate.SqlValidatorUtil; unused import: org.apache.calcite.sql.validate.SqlValidatorUtil http://gerrit.cloudera.org:8080/#/c/24211/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@58 PS7, Line 58: import java.util.ArrayList; unused import: java.util.ArrayList http://gerrit.cloudera.org:8080/#/c/24211/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@59 PS7, Line 59: import java.util.HashSet; unused import: java.util.HashSet http://gerrit.cloudera.org:8080/#/c/24211/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@60 PS7, Line 60: import java.util.List; unused import: java.util.List http://gerrit.cloudera.org:8080/#/c/24211/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@62 PS7, Line 62: import java.util.Set; unused import: java.util.Set -- To view, visit http://gerrit.cloudera.org:8080/24211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d0229c8907f69e648034d12fe375d9d9a384e25 Gerrit-Change-Number: 24211 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 25 Jun 2026 14:42:53 +0000 Gerrit-HasComments: Yes
