Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24017 )
Change subject: IMPALA-14484: Calcite planner: Add column stats to union slot descriptors ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24017/5/fe/src/main/java/org/apache/impala/analysis/SetOperationStmt.java File fe/src/main/java/org/apache/impala/analysis/SetOperationStmt.java: http://gerrit.cloudera.org:8080/#/c/24017/5/fe/src/main/java/org/apache/impala/analysis/SetOperationStmt.java@701 PS5, Line 701: for (int i = 0; i < resultExprsList.size(); ++i) { nit: could clean these loops up with com.google.common.collect.Streams.zip and pre-allocating columnStats and sourceColumns. http://gerrit.cloudera.org:8080/#/c/24017/1/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q38.test File testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q38.test: http://gerrit.cloudera.org:8080/#/c/24017/1/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q38.test@46 PS1, Line 46: ImpalaFilterRel(condition=[AND(SEARCH($3, Sarg[[1222..1233]]), IS NOT NULL($0))]) > Yeah, heh, that is a big change :) Ack -- To view, visit http://gerrit.cloudera.org:8080/24017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0585fafa45658dffffdbf6410b028f03304b6e9 Gerrit-Change-Number: 24017 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 25 Jun 2026 20:35:23 +0000 Gerrit-HasComments: Yes
