Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24505 )
Change subject: IMPALA-15083: [Part 1] Add Parquet UUID read support for Iceberg tables ...................................................................... Patch Set 2: (1 comment) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/24505/2/be/src/exec/parquet/parquet-column-readers.cc File be/src/exec/parquet/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/24505/2/be/src/exec/parquet/parquet-column-readers.cc@899 PS2, Line 899: // Allocate 36 bytes for the UUID string from the data page pool. : // Mark keep_data_page_pool_ so the allocation survives. We shouldn't allocate anything here, just copy the 16 bytes to the tuple's UUID slot. I.e. we should treat UUID like a CHAR(16). This way we save a lot of memory and unnecessary allocations, and also avoid pointer chasing. -- To view, visit http://gerrit.cloudera.org:8080/24505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4157c002e80677d27d8fd060c7bfa07b95d7c78f Gerrit-Change-Number: 24505 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 25 Jun 2026 21:08:24 +0000 Gerrit-HasComments: Yes
