Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10843 )
Change subject: IMPALA-4784: Remove InProcessStatestore ...................................................................... IMPALA-4784: Remove InProcessStatestore InProcessStatestore was only used by statestore-test, expr-test and session-expiry-test. With a slight refactor of the Statestore class, InProcessStatestore becomes obsolete. This patch moves the ownership of the ThriftServer into the Statestore class and Statestore::Init() now takes a 'port' parameter instead of using the FLAGS_state_store_port directly. We also remove the InProcessStatestore completely. A follow on patch will get rid of the InProcessImpalaServer too (IMPALA-6013) Testing: Ran 'core' tests. Change-Id: I2621873e593b36c9612a6402ac6c5d8e3b49cde9 Reviewed-on: http://gerrit.cloudera.org:8080/10843 Reviewed-by: Sailesh Mukil <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exprs/expr-test.cc M be/src/service/session-expiry-test.cc M be/src/statestore/statestore-test.cc M be/src/statestore/statestore.cc M be/src/statestore/statestore.h M be/src/statestore/statestored-main.cc M be/src/testutil/in-process-servers.cc M be/src/testutil/in-process-servers.h 8 files changed, 95 insertions(+), 125 deletions(-) Approvals: Sailesh Mukil: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10843 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2621873e593b36c9612a6402ac6c5d8e3b49cde9 Gerrit-Change-Number: 10843 Gerrit-PatchSet: 7 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
