Hello Fang-Yu Rao, Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24510
to look at the new patch set (#2).
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users
by default
......................................................................
IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
Most of the users turn this on to resolve the performance regression on
INVALIDATE and REFRESH commands. The regression is due to additional
metadata loading if the table is unloaded in catalogd. Though this is
resolved by IMPALA-14703, i.e. don't need metadata loading anymore,
checking table masking policies is still an additional work. Setting
allow_catalog_cache_op_from_masked_users to true skips this check.
Test Changes:
- Moved the negative test (test_block_metadata_update) to
TestRangerIndependent since it now requires restarting the cluster
with the flag off. Also mirrored it to test on both catalog modes.
- Moved the positive tests, test_allow_metadata_update_legacy_catalog
and test_allow_metadata_update_local_catalog to
TestRangerLocalCatalog and TestRangerLegacyCatalog respectively since
they don't need cluster restart now.
- Modified _test_allow_catalog_cache_op_from_masked_users since it's
not running at cold start anymore.
- For FE tests that depend on this flag to be false, explicitly set it
before the tests.
Tests
- Ran CORE tests
Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
---
M be/src/service/frontend.cc
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
M
fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java
M tests/authorization/test_ranger.py
5 files changed, 65 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/24510/2
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
